[trunk] Unable to edit staff instrument names (regression)
S4 - Minor
Steps to reproduce bug
1. Open bach-bc2 demo (or any score with instrument names)
2. Double click on the instrument name "Trumpet" (in front of the first staff)
Expected behavior: Trumpet should now be editable text
Actual behavior: Nothing happens
MuseScore version: r. 3661 nightly trunk
(Operating System: Windows 7)
It's recent regression due to the fix of #7729: Delete, undo crash for pages with multi-text frames
Instrument names are created (and deleted) automatically in MuseScore. They are a property of the actual selected instrument and can be edited in the staff/instrument property menu. Previous versions allowed to edit instrument names directly in the score and did some special handling to update all instrument names to the edited one.
The problem was that it looks like you were able to modify a single instrument name. But you could not, which sometimes produces some confusion.
Unfortunately the old implementation had some problems with undo/redo and would require more special handling.
So i favour of a clean user interface model i removed this functionality.
Should this be marked as such?
Fixed in branch master, commit 1bc87d891b
[MU4] Fix #7767 - ensure undo works properly for staff properties dialog
Fixed in branch master, commit 7748e3d281
_Merge pull request #8586 from wizofaus/fix_undo_staff_properties
[MU4] Fix #7767 - ensure undo works properly for staff properties dialog_