Some elements duplicated on time sig change

• Mar 1, 2015 - 09:39
S4 - Minor

Context: commit a59103f (2015-02-26) self-complied with Qt Lib 5.3 and Qt Creator 3.3.0 under Linux Mint 17 64-bit.


  1. Create a score with, say, 3/4 time sig (or load the attached sample score, screen shot 1)
  2. Change time sig to one not mathematically equivalent to the original (i.e. was total legnht is different), for instance 9/8 (screen shot 2)

Expected result: if a note is split between two consecutive measures, only the first part of the note carries the lyrics.

Result: When a note is split, lyrics appear at both parts of the note.

From THIS:



FWIW, not just lyrics. Also articulations, chordlines, arpeggios, fingering - basically anything attached to the chord or any note.

This is probably an uncommon enough thing, and easy enough to spot and fix, to not worry *too* much about. But it's probably also a very simple fix.

Status (old) active patch (code needs review)

Same thing is true for ties created as a result of copy and paste. That is, a half note on beat 3 of a 4/4 measure, copied and pasted to beat 4 of another measure and tied across to beat 1 of the next. If the source has lyrics or other markings, they are copied to both tied notes.

Here is a PR that fixes the issue - at least the symptoms I know of - for both cases (paste and time signature change). Probably the problem should be solved just once and used in both places rather than having the code duplicated. But the following does work: