Play panel and Synthesizer: double-clicking the master fader resets Master Volume to wrong level (-20db)

• Jul 8, 2019 - 18:16
Reported version
P2 - Medium
Ergonomical (UX)
S3 - Major

Win 7/10. MS 3.2.3 (Official).

Caution: For reasons of safety (due to potentially high volume levels), use a blank score. Do not play back anything while testing.

  1. Open the Play panel.
  2. Change the position of all the sliders then double-click on all of them.
    Expected result: All values return to the default.
    Actual result: Master Volume is reset to -20 db rather than the default -40 db.


In reply to by Marc Sabatella

What level should double click set? At the moment the PlayPanel double clicks yields -20.0db (that's in Play Panel units, as it were). Looking at the code, the PlayPanel doesn't override the default double-click value for that slider, which is probably why it's a rather unhelpful value. It's a one line fix once a sensible value is identified.

The mixer dB measurement is set on a different scale to the PlayPanel and I'm not sure which one is right (if either) - reported at:

I'm thinking a sensible level for double click might be around -50dB in Play Panel units which, at the moment, is about -1.55dB in Mixer Master Gain units. But, as with #291453, it's not clear (or not to me) what dB scales are appropriate.

Title Play panel: Double-click resets Master Volume to wrong level Play panel and Synthesizer: double-clicking the master fader resets Master Volume to wrong level (-20db)

The synthesizer has exactly the same problem. If you double click the master fader it resets to -20db—regardless of the master volume saved by the user (i.e. by pressing the "Set as Default" button). IMV, when a master fader is double-clicked, it should reset all master faders (Play panel, Synthesizer, Mixer) to the default master volume.

Related to #292995: [EPIC] Synthesizer issues.

In reply to by geetar

Yes it does and that was also identified (by Jojo in a GitHub comment) when I submitted the initial PR. The PR has been revised to sort out the synthesiser case and add double-click to reset master volume in the mixer. The PR makes the default -40dB which is the default for MuseScore on startup. If there's a desire to change that, the post this PR that can now be done in just one place in the codebase.

Status PR created fixed

Fixed in branch master, commit 8bac1fddde

_Fix #291901 & Fix #291453 Double-click resets Master Volume

  • put all the decibel conversion work into MasterSynthesizer
  • make a default gain value available from MasterSynthesizer
  • add double click for default value support to StyledSlider
  • amend PlayPanel, Mixer and SynthControl to interact with MasterSynthesizer only using decibels and making use of the provided default gain for double click
  • Fix #291453 is addressed as the Mixer now uses the default decibel range_
Fix version